Skip to content

(Feat): Add backtrace collection for rspec#1070

Merged
trunk-io[bot] merged 2 commits intomainfrom
tyler/backtrace-storage
Apr 17, 2026
Merged

(Feat): Add backtrace collection for rspec#1070
trunk-io[bot] merged 2 commits intomainfrom
tyler/backtrace-storage

Conversation

@TylerJang27
Copy link
Copy Markdown
Collaborator

@TylerJang27 TylerJang27 commented Apr 17, 2026

We got a user request to include richer failure information from the rspec gem, including backtraces.

I've done the following:

  1. Move the message that we were capturing to failure_message to match what we usually see in other junit reporters
  2. Capture the backtrace if it's present and wire it into failure_text, which usually includes the backtrace in other junit reporters
  3. Truncate both to 8000 characters, which is what we limit internally (but also just to avoid inflating bundle sizes).

I ran the above on an example Capybara repo and got the following:

      "test_case_runs": [
        {
          "id": "",
          "name": "Full page example (scrolling) Full page test",
          "classname": "spec.capybara_spec",
          "file": "./spec/capybara_spec.rb",
          "parent_name": "Full page example (scrolling)",
          "line": 15,
          "status": 2,
          "attempt_number": 0,
          "started_at": "2026-04-17T04:41:57Z",
          "finished_at": "2026-04-17T04:41:57Z",
          "status_output_message": "session not created: Chrome instance exited. Examine ChromeDriver verbose log to determine the cause.",
          "is_quarantined": false,
          "codeowners": [],
          "attempt_index": {
            "number": 0
          },
          "line_number": {
            "number": 15
          },
          "test_output": {
            "text": "/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/response.rb:63:in 'Selenium::WebDriver::Remote::Response#add_cause'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/response.rb:41:in 'Selenium::WebDriver::Remote::Response#error'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/response.rb:52:in 'Selenium::WebDriver::Remote::Response#assert_ok'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/response.rb:34:in 'Selenium::WebDriver::Remote::Response#initialize'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/http/common.rb:135:in 'Selenium::WebDriver::Remote::Http::Common#create_response'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/http/default.rb:103:in 'Selenium::WebDriver::Remote::Http::Default#request'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/http/common.rb:70:in 'Selenium::WebDriver::Remote::Http::Common#call'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/bridge.rb:633:in 'Selenium::WebDriver::Remote::Bridge#execute'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/remote/bridge.rb:76:in 'Selenium::WebDriver::Remote::Bridge#create_session'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/common/driver.rb:325:in 'block in Selenium::WebDriver::Driver#create_bridge'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/common/driver.rb:324:in 'Kernel#tap'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/common/driver.rb:324:in 'Selenium::WebDriver::Driver#create_bridge'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/common/driver.rb:73:in 'Selenium::WebDriver::Driver#initialize'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/chrome/driver.rb:35:in 'block in Selenium::WebDriver::Chrome::Driver#initialize'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/common/local_driver.rb:31:in 'Selenium::WebDriver::LocalDriver#initialize_local_driver'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/chrome/driver.rb:34:in 'Selenium::WebDriver::Chrome::Driver#initialize'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver/common/driver.rb:47:in 'Selenium::WebDriver::Driver.for'\n/home/tyler/.gem/gems/selenium-webdriver-4.43.0/lib/selenium/webdriver.rb:88:in 'Selenium::WebDriver.for'\n/home/tyler/.gem/gems/capybara-3.40.0/lib/capybara/selenium/driver.rb:75:in 'Capybara::Selenium::Driver#browser'\n/home/tyler/.gem/gems/eyes_capybara-6.6.29/lib/applitools/capybara/driver.rb:13:in 'Applitools::Selenium::Capybara::Driver#browser'\n/home/tyler/.gem/gems/eyes_capybara-6.6.29/lib/applitools/capybara/driver.rb:8:in 'Applitools::Selenium::Capybara::Driver#driver_for_eyes'\n/home/tyler/.gem/gems/eyes_capybara-6.6.29/lib/applitools/capybara/driver.rb:32:in 'Capybara::Session#driver_for_eyes'\n/home/tyler/.gem/gems/eyes_selenium-6.12.29/lib/applitools/selenium/selenium_eyes.rb:24:in 'Applitools::Selenium::SeleniumEyes.eyes_driver'\n/home/tyler/.gem/gems/eyes_core-6.10.2/lib/applitools/core/universal_eyes_open.rb:29:in 'Applitools::UniversalEyesOpen#universal_open'\n/home/tyler/.gem/gems/eyes_selenium-6.12.29/lib/applitools/selenium/selenium_eyes.rb:149:in 'Applitools::Selenium::SeleniumEyes#open'\n/home/tyler/.gem/gems/eyes_selenium-6.12.29/lib/applitools/selenium/concerns/selenium_eyes.rb:108:in 'Applitools::Selenium::Concerns::SeleniumEyes#test'\n/snap/ruby/447/lib/ruby/4.0.0/delegate.rb:88:in 'Delegator#method_missing'\n/home/tyler/repos/RSpec-Capybara-example/spec/capybara_spec.rb:18:in 'block (2 levels) in <top (required)>'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:263:in 'BasicObject#instance_exec'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:263:in 'block in RSpec::Core::Example#run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:511:in 'block in RSpec::Core::Example#with_around_and_singleton_context_hooks'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:468:in 'block in RSpec::Core::Example#with_around_example_hooks'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/hooks.rb:486:in 'block in RSpec::Core::Hooks::HookCollections#run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/hooks.rb:626:in 'block in RSpec::Core::Hooks::HookCollections#run_around_example_hooks_for'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:352:in 'RSpec::Core::Example::Procsy#call'\n/home/tyler/repos/analytics-cli/rspec-trunk-flaky-tests/lib/trunk_spec_helper.rb:178:in 'RSpec::Trunk#run'\n/home/tyler/repos/analytics-cli/rspec-trunk-flaky-tests/lib/trunk_spec_helper.rb:148:in 'RSpec::Core::Example::Procsy#run_with_trunk'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:457:in 'BasicObject#instance_exec'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:457:in 'RSpec::Core::Example#instance_exec'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/hooks.rb:390:in 'RSpec::Core::Hooks::AroundHook#execute_with'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/hooks.rb:628:in 'block (2 levels) in RSpec::Core::Hooks::HookCollections#run_around_example_hooks_for'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:352:in 'RSpec::Core::Example::Procsy#call'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/hooks.rb:629:in 'RSpec::Core::Hooks::HookCollections#run_around_example_hooks_for'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/hooks.rb:486:in 'RSpec::Core::Hooks::HookCollections#run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:468:in 'RSpec::Core::Example#with_around_example_hooks'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:511:in 'RSpec::Core::Example#with_around_and_singleton_context_hooks'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example.rb:259:in 'RSpec::Core::Example#run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example_group.rb:653:in 'block in RSpec::Core::ExampleGroup.run_examples'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example_group.rb:649:in 'Array#map'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example_group.rb:649:in 'RSpec::Core::ExampleGroup.run_examples'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/example_group.rb:614:in 'RSpec::Core::ExampleGroup.run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:121:in 'block (3 levels) in RSpec::Core::Runner#run_specs'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:121:in 'Array#map'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:121:in 'block (2 levels) in RSpec::Core::Runner#run_specs'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/configuration.rb:2097:in 'RSpec::Core::Configuration#with_suite_hooks'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:116:in 'block in RSpec::Core::Runner#run_specs'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/reporter.rb:74:in 'RSpec::Core::Reporter#report'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:115:in 'RSpec::Core::Runner#run_specs'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:89:in 'RSpec::Core::Runner#run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:71:in 'RSpec::Core::Runner.run'\n/home/tyler/.gem/gems/rspec-core-3.13.6/lib/rspec/core/runner.rb:45:in 'RSpec::Core::Runner.invoke'\n/home/tyler/.gem/gems/rspec-core-3.13.6/exe/rspec:4:in '<top (required)>'\n/snap/ruby/447/lib/ruby/4.0.0/rubygems.rb:303:in 'Kernel#load'\n/snap/ruby/447/lib/ruby/4.0.0/rubygems.rb:303:in 'Gem.activate_and_load_bin_path'\n/home/tyler/.gem/bin/rspec:25:in '<top (required)>'\n/snap/ruby/447/lib/ruby/4.0.0/bundler/cli/exec.rb:61:in 'Kernel.load'\n/snap/ruby/447/lib/ruby/4.0.0",
            "message": "session not created: Chrome instance exited. Examine ChromeDriver verbose log to determine the cause.",
            "system_out": "",
            "system_err": ""
          },
          "test_runner_information": null
        },

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 17, 2026 •
edited
Loading

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io bot commented Apr 17, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.96%. Comparing base (b43a977) to head (4d5f80e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   81.70%   81.96%   +0.26%     
==========================================
  Files          69       69              
  Lines       14878    14879       +1     
==========================================
+ Hits        12156    12196      +40     
+ Misses       2722     2683      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TylerJang27
Copy link
Copy Markdown
Collaborator Author

TylerJang27 commented Apr 17, 2026

@claude review

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 17, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

dfrankland
dfrankland approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dfrankland dfrankland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZ

@trunk-io trunk-io bot merged commit 2c3d07b into main Apr 17, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfrankland dfrankland dfrankland approved these changes

@max-trunk max-trunk Awaiting requested review from max-trunk

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TylerJang27 @codecov-commenter @dfrankland